search

pipipipi2002 / pe

0 stars 0 forks source link

Numbers in the sequence diagram in the DG #14

Open pipipipi2002 opened 1 year ago

pipipipi2002 commented 1 year ago

I am not sure whether the UML standard of CS2113 has numbers influction of the method calls to signify order.

One example is

Screen Shot 2022-11-11 at 20.44.23.png

Moreover, I dont see such numbering at the first few pages of the DG, for example,

Screen Shot 2022-11-11 at 20.45.42.png

nus-pe-bot commented 1 year ago

Team's Response

Those numbers do not hinder the understanding of the sequence diagram.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Following the CS2113 standards, there is no number in the sequence diagram, thus I do not think we are expected to add extra words. Moreover, the arrow is a function call and the caption for the arrow is the function being called. Moreover, the team should have been consistent on the diagram, so as not to confuse other developer reading this guide. It can be considered not neat as the team does not seem to have communicated poorly to have caused this stark different in the uml diagrams.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: Due to not following the syntax CS2113 has laid out and being inconsistent in their diagram convention, i maintain my stand on this bug being a low severity