piplabs / story

Official repo for the Story L1 consensus client, contracts, and associated tooling.
GNU General Public License v3.0
38 stars 26 forks source link

Support running nodes using Docker #153

Open LuttyYang opened 2 months ago

LuttyYang commented 2 months ago

Support running nodes using Docker:

  1. Coinbase requires the RPC node to run using Docker: Please ensure that your Dockerfile and related files such as entrypoint.sh:

    • Are contained within a single Dockerfile
    • Can be built and run on both Linux/Unix and macOS
    • Use Ubuntu:20+ other than Alpine or Debian as the base image
    • Support both testnet and mainnet deployment
    • Provide a method to sync from snapshots in both testnet and mainnet (optional for day 1 asset)
    • The node cannot prune data after deployment
  2. Developers can use Docker to run localnet for easier testing and development.

bert2002 commented 1 month ago

Hi, was looking for a docker image for story and story-geth. I see the PR and see the approach. I think its nice to have the configurations for a local devnet, but a docker image actually should not have any configuration files, etc. Just a slim container with the binaries and running as a non-root user is perfect. Everything else should be read from environment or configurations mapped into the container. This keeps the image usable for different networks and decreases the management for your team and dont need to release new images if a configuration needs to be fixed, which will confuse other teams.

bert