search

pipoteam / pipobot

A modular bot for Jabber MUCs.
16 stars 9 forks source link

Explicit error message if pipo can’t get a JID #3

Closed nim65s closed 12 years ago

sleduc commented 12 years ago

To solve the issue of non-retrieving JID, VinDuv proposed : https://github.com/VinDuv/pipobot/commit/99f6a950cb127f56d9e450723e63243adb51bab3

This should fix the bot so it will not have problems with JID any more (of course the issue of "stealing" nickname remains but it may be the best we can do in cases whre the bot really can't read JID). VinDuv has done a lot of refactoring in the code so I don't know when it will be proposed to be merged / will be merged but I guess it should fix your issue.

sleduc commented 12 years ago

The commit has been merged to master so the problem should be solved : if the bot can't read jids in a room, a "fake" jid will be generated with nickname@chat.invalid and it will not fail.

Nevertheless one should keep in mind that modules based on jid could be "hacked" if a user is usurping a nickname and that configuring the room/the bot so it can read JIDs is preferable :p