search

pippyn / Home-Assistant-Sensor-Afvalbeheer

Provides Home Assistant sensors for multiple Dutch and Belgium waste collectors
Apache License 2.0
277 stars 86 forks source link

Overwrite waste types #500

Open hilsonp opened 3 weeks ago

hilsonp commented 3 weeks ago

Hello,

Can we overwrite waste type strings by configuration ? For example, WASTE_TYPE_GREY is 'Restafval' and I would like to set it to 'Ordures-Ménagères' or simply 'Grises'.

Thank you,

Pierre

pippyn commented 2 weeks ago

Hi Pierre,

Thanks for your question. At the moment the french translation is not finished yet. It still needs some work. For now you can create template sensors to translate the states in your desired naming.

hilsonp commented 2 weeks ago

Hello,

Thank you for your reply.

Addressing this through translation(s) might be a never ending story as there are many languages out there. Additionally, one may not like the term you would have implemented.

This is why I thought that being able to provide custom names for wasted types would suit every one needs without requiring (yet another) template.

This is already defined as a series of constants in the code and thought it would be really easy to externalise in a configuration file.

Well. I hear you. I should submit a PR 😌

Thank you anyway for your nice work 👍

This comment is ment to be constructive and is not a critiscism or a complaint.