search

pipwerks / PDFObject

A lightweight JavaScript utility for dynamically embedding PDFs in HTML documents.
http://pdfobject.com/
Other
2.38k stars 985 forks source link

pdfOpenParams with toolbar #272

Closed alainrc2005 closed 1 year ago

alainrc2005 commented 2 years ago

In version 2.2.7 this work { pdfOpenParams: { toolbar: '0' } } but in version 2.2.8 this not work

theodore-s-beers commented 2 years ago

@pipwerks, I think this is actually a bug. As of the 2.2.8 updates/refactor (commit e72762d), pdfOpenParams isn't being included at all, except when PDF.js is used.

pipwerks commented 2 years ago

Thanks both. I will check it out

pipwerks commented 2 years ago

Fixed in 2.2.9 branch, needs testing before I can publish to NPM. Will try to test asap

alainrc2005 commented 2 years ago

Thanks Very Much

On Sun, Jul 31, 2022 at 2:03 AM Philip Hutchison @.***> wrote:

Fixed in 2.2.9 branch, needs testing before I can publish to NPM. Will try to test asap

— Reply to this email directly, view it on GitHub https://github.com/pipwerks/PDFObject/issues/272#issuecomment-1200356140, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFONK7TB3KX25THGOOQCPNDVWYJMVANCNFSM54BT6YQA . You are receiving this because you authored the thread.Message ID: @.***>

pipwerks commented 1 year ago

Hi all. I've behind on testing, been busy with work and other projects. I'm curious if anyone has tested the 2.2.9 branch. I will try and wrap it up this weekend, would be great if others can share any testing results.

pipwerks commented 1 year ago

Resolved with 2.2.9 release