Closed DavidCo113 closed 1 year ago
xtreme8000 why the confused emoji? I'm pretty sure my modifications should be fine.
I think the protocol flow should be documented, maybe changing the part that says it "must" be sent, but its recommended to send when client connects, same for the client. So, people know when the server interacts with the client to talk about extensions.
@DryByte Is this a little better?
I dont think it needs to be after version info response, and mentioning which client versions supports the ext info isnt needed.
@DryByte Well the thing is old clients crashed iirc
https://github.com/piqueserver/piqueserver/issues/504 it "confuses the heuristics" or something
Oh ok, linking that issue to the text maybe is a good idea.
@DryByte issue included
Reasons for the corrections: Just using 'n' is a little bit confusing, so I change it to "length".
length+1 entries do not follow, just length follows. This agrees with the 2+2*length thing positioned just above the statement.
All extensions that I have seen have had a version of 1, so I change it to reflect that.
The server does not need to send an ExtInfo packet on connect at all, since extensions are... extensions. They are optional additions that are not an official part of the AoS v0.75 protocol. The same can be said for the client (and if the length+1 thing were true there would be no way to not support extensions without making up a fake one). And there is no need to omit any extensions that the server does not support as the server can simply ignore extensions that it does not support. So I delete this entire section.
I also fix some spacing that was messed up on a markdown table.