Make CRDs part of helm charts

piraeusdatastore / helm-charts

Collection of useful charts for Piraeus and similar projects

Apache License 2.0

31 stars 18 forks source link

Make CRDs part of helm charts #5

Closed z0rc closed 3 years ago

z0rc commented 3 years ago

CRDs outside of chart make installation via CI pipelines rather tedious process, as we need to manage CRD lifecycle separately from rest of the chart.

WanzenBug commented 3 years ago

Hi!

Having CRDs outside the chart was a deliberate choice on my part. My reasons are:

Helm doesn't upgrade CRDs. After the initial installation, users would still have to run kubectl replace -f ..... See here
We'd need to include the CRDs in this repo, meaning more work to keep the Chart in sync.

z0rc commented 3 years ago

Thing is CI/CD tools (like helmfile, ArgoCD) that work with helm charts can handle CRDs upgrades (they are using helm template under hood instead of helm install). Or as helm docs recommends, move CRDs into their own helm chart.