search

piraeusdatastore / piraeus-operator

The Piraeus Operator manages LINSTOR clusters in Kubernetes.
https://piraeus.io/
Apache License 2.0
412 stars 64 forks source link

app.kubernetes.io/name should not be the same #719

Open maxpain opened 1 month ago

maxpain commented 1 month ago

Hello.

Currently, all the pods in piraeus-datastore namespace have the same app.kubernetes.io/name=piraeus-datastore label, which is not ideal.

For example, it's used in Hubble UI as an identity for traffic flows.

Screenshot 2024-10-12 at 20 40 17
WanzenBug commented 1 month ago

That is unfortunate. I guess we should have used app.kubernetes.io/part-of: piraeus-datastore instead.

However, because this label is included in the selectors, I'm hesitant to change it, as that would require a complete delete/recreate of the deployments.