search

pirafrank / google-toolbox-for-mac

Automatically exported from code.google.com/p/google-toolbox-for-mac
Apache License 2.0
0 stars 0 forks source link

GTMScriptRunner: run:standardError: deadlocks with full error pipe #25

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
When GTMScriptRunner is used to call a script which generates a lot of output 
in stderr, the 
run:standardError: method deadlocks because the [fromTask readDataToEndOfFile] 
waits for the 
script to terminate and the script waits for the runner to collect from the 
full stderr pipe.

Original issue reported on code.google.com by frank.il...@googlemail.com on 27 May 2009 at 8:26

GoogleCodeExporter commented 9 years ago 
not yet fixed, but I'm adding a unittest that can be used to work on this and 
that will help make sure we don't 
regress once it's fixed.

Original comment by thoma...@gmail.com on 3 Jun 2009 at 5:07

GoogleCodeExporter commented 9 years ago 
Just a note that this issue causes an annoying bug in the CoverStory app:
https://code.google.com/p/coverstory/issues/detail?id=21

Original comment by dlre...@gmail.com on 19 Feb 2013 at 11:00

GoogleCodeExporter commented 9 years ago 
I believe I've got a fix for this. The solution is to keep both pipes (stdout 
and stderr) empty. To do that we needed a non-blocking way to check for 
available data. I've attached a patch that does this.

Original comment by dlre...@gmail.com on 20 Feb 2013 at 6:33

Attachments:

GoogleCodeExporter commented 9 years ago 
dlreese - Have you filled out 
https://code.google.com/p/google-toolbox-for-mac/wiki/BecomingAContributor so 
we can take a look at the patch?

Original comment by thoma...@gmail.com on 21 Feb 2013 at 3:24

GoogleCodeExporter commented 9 years ago 
I have now. :) Sorry about the delay. I didn't realize there was an official 
form to submit.

Original comment by dlre...@gmail.com on 21 Feb 2013 at 4:21

GoogleCodeExporter commented 9 years ago 
The solution in comment #3 by dlreese worked for me.
Project member please fix this and release new version of CoverStory ASAP.

Original comment by naveen.s...@gmail.com on 8 Mar 2013 at 10:51

GoogleCodeExporter commented 9 years ago

Original comment by dmaclach on 11 Jul 2013 at 5:44

GoogleCodeExporter commented 9 years ago 
Patch applied. Thank you dlreese, and apologies for the delay.

Original comment by dmaclach on 12 Jul 2013 at 4:56

GoogleCodeExporter commented 9 years ago 
Thanks! :)

Original comment by dlre...@gmail.com on 12 Jul 2013 at 7:41