Closed a-h closed 4 years ago
Hey! Thanks, I like the idea, but travis ci fails. :) I'm not developing a lot in Go right now so I'm not too familiar with Go modules and errors do not seem very understandable to me. Can you take a look at them? :)
I fixed the tests. I'd never seen cram
before, looks like a useful tool.
If a project uses Go modules (has a go.mod
file), there's no need to do a go get
before building, go build
will automatically download any missing packages and store them in a global cache, so I removed it.
However, the first thing the cram
test was doing was building goreplace
using the package name. This makes Go look for the package in the GOPATH, so it failed because the removal of the go get
command from the Makefile
meant that the required dependencies weren't there.
I fixed it by switching the test to building gr
based on the source code file path instead of the package name.
Makes sense, thanks! :-)
Hi, great tool, thanks!
This doesn't do anything new, just adds the Go module files.
I'm not sure if this is particularly an improvement aside from pinning versions of the dependencies and enabling Github Dependabot to analyse the project, but it makes it easier for me to package the app using Nix, which is why I have a fork (Nix expression below, in case anyone is looking).