search

piranhacloud / piranha

Piranha - a modern cloud runtime
https://piranha.cloud
BSD 3-Clause "New" or "Revised" License
195 stars 20 forks source link

Rewrite tests in our test directory to use our Arquillian connector where possible #1004

Closed manorrock closed 3 years ago

manorrock commented 4 years ago

Go to https://github.com/javaee-samples/javaee7-samples for some example usage of our Arquillian connector

Thihup commented 4 years ago

For now we've a lot of tests using the Piranha embedded that can be used as example as well. Should we just rewrite them or create new tests equally in functionality but using Arquillian?

manorrock commented 4 years ago

Piranha Embedded gets enough testing because of being used in unit testing. So I would like to the tests in the test directory to be rewritten as Arquillian tests and thus enlarge our testing of Piranha Micro

manorrock commented 4 years ago

@Thihup Did I give you enough information?

Thihup commented 4 years ago

@manorrock Sure! I was rewriting some tests, however, most of the tests that I tried to rewrite (Jersey, for instance) fail because the CDI tries to inject where isn't supposed to inject. I was trying to figure out how to rework the CDI injection because for now, it passes all classes to Weld manage and some of them aren't supposed to be managed by Weld. There's only one thing I don't know which way would be better: move the refactored tests to tests/arquillian or refactor in-place.

manorrock commented 4 years ago

Mmmm, that sounds like the default extension is doing too much? It sounds like we should not enable CDI by default? What do you think? @arjantijms

Thihup commented 4 years ago

Unfortunately, I think we cannot simply disable the CDI because the whole security implementation depends on it.

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 170 days with no activity. Remove stale label or comment or this will be closed in 10 days