search

piranhacloud / piranha

Piranha - a modern cloud runtime
https://piranha.cloud
BSD 3-Clause "New" or "Revised" License
193 stars 20 forks source link

Get the same HttpSession if available #1529

Closed Thihup closed 3 years ago

Thihup commented 3 years ago

Myfaces relies on the HttpSession to work. When it wants to set an attribute, it calls request.getSession(true), but now we are creating a new session everytime this method is called. It should reuse the same session if available.

Related #1498

manorrock commented 3 years ago

Mmmm that should work. I admit it has been a while since I looked at that particular area of the code.

Thihup commented 3 years ago

I need to take a better look. I guess it is not working when the JSESSIONID is invalid.

Thihup commented 3 years ago

Well, it is working. Yesterday when I looked it was returning a new session with the empty attributes, causing the request to fail, but probably it was some browser cache as now it is working 🤷🏼‍♂️