piratar / wasa2il

Direct democracy system
https://x.piratar.is
Other
28 stars 16 forks source link

Get rid of discussion time and proposal time limit in issue #194

Closed helgihg closed 6 years ago

helgihg commented 6 years ago

Discussions should be allowed until voting in issues is concluded.

Currently, the code assumes that discussions should end before voting begins. There appears to be no particular reason for this. As a result, administrators must manually edit issues once they've been created, in order to allow more time for discussions once the vote has started.

In fact, there is a particular field, deadline_discussions, which seems to originally have been intended to end prior to deadline_proposals.

Deadline_proposals is another feature that isn't used, nor ever has been. It was probably intended to be a part of a functionality that was never implemented.

As a result, we should remove both deadline_discussions and deadline_proposals, allow comments until the end of the voting period, and replace deadline_proposals with starttime_votes or something to that effect (like in the Election app), for the ability to start the vote later than immediately.

helgihg commented 6 years ago

While implemented differently than proposed in the issue, this has been resolved in https://github.com/piratar/wasa2il/commit/d6d538d7308d63a75275afa53d92d46f23b4b717.