search

piratar / wasa2il

Direct democracy system
https://x.piratar.is
Other
28 stars 16 forks source link

Commonmark package update breaks `master` and `development` branch #214

Closed viktorsmari closed 5 years ago

viktorsmari commented 5 years ago

On the newest master and development using virtualenv the change from CommonMark 0.7.5 to commonmark-0.8.1 in requirements.txt breaks the application with error:

InvalidTemplateLibrary at /
Invalid template library specified. ImportError raised when trying to load 'prosemirror.templatetags.prosemirror': No module named CommonMark.blocks

Reverting the package solves the issue.

How can we stop these basic errors from going into the master branch? Don't we have any tests on Travis that can forbid merging these PRs into a branch?

viktorsmari commented 5 years ago

Travis tried to warn us with a red :x: :laughing: but not sure if related to the commonmark problem 2018-10-21_16-32-18

helgihg commented 5 years ago

Travis was set put in place by a previous developer, and I was unable to figure out what went wrong, and since no one was around to maintain the Travis testing thing, I disabled it.

On Sun, Oct 21, 2018 at 2:33 PM Viktor Smári notifications@github.com wrote:

Travis tried to warn us with a red ❌ 😆 [image: 2018-10-21_16-32-18] https://user-images.githubusercontent.com/1689020/47268260-f3d83b80-d54e-11e8-8f72-f3413e608d79.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/piratar/wasa2il/issues/214#issuecomment-431673903, or mute the thread https://github.com/notifications/unsubscribe-auth/ABnqCbGM9NdP21nnQLAPURQwUymGchm5ks5unIW4gaJpZM4XyfRR .

viktorsmari commented 5 years ago

@helgihg I volunteer to maintain mr Travis!

viktorsmari commented 5 years ago

@helgihg Travis has been fixed. The API key ran out, it needs to be renewed yearly. However, we still have errors on the app itself on https://wasa2il-development.herokuapp.com/ We need to look at #212 (Simplify Settings files) which will also close #216 (demo page)