search

piratar / wasa2il

Direct democracy system
https://x.piratar.is
Other
28 stars 16 forks source link

Align font awesome icons with the fa-fw class #230

Closed viktorsmari closed 2 years ago

viktorsmari commented 5 years ago

Also minor code re-format. Put a in its own line

Before 2019-08-08_22-08-33

After 2019-08-08_22-08-48

tomage commented 2 years ago

Did just look at the conflicts, and it does seem like the icons were mostly fixed in development. Might still be worth resolving the conflict, and merge in whatever is left :)

viktorsmari commented 2 years ago

Feel free to merge or close if the issue has already been fixed on development!

tomage commented 2 years ago

So.. I believe I have updated the patch with latest from development branch (I rebased your commit on latest development, and resolved the conflicts the best I could).

Really, all the patch is is:

  1. Adding in fa-fw class wherever fas class is being used.
  2. Formatted the HTML a bit, similar to the original patch (brought the 's down into it's own level).

So I believe the patch is true to what it was before, but it might be good for someone to review it and give :+1: - perhaps you've got time @viktorsmari ?

viktorsmari commented 2 years ago

LGTM :+1: