piratesephiroth / TeconmoonWiiVCInjector

Fork of the popular Wii Virtual Console Injector for Wii U by Teconmoon
132 stars 20 forks source link

Large Code Cleanup #41

Open QuzarDC opened 8 months ago

QuzarDC commented 8 months ago

Hi! I'd used your tool in setting up injections on my WiiU and thought I might help out with some cleanups. I tried to make the commits fairly atomic so that they could be actually reviewable. Most of it is refactoring and condensing the code (attempting to de-'SUPER CRAPPY' it). Along the way also fixed some bugs:

1) Fix exception on error if temp folder missing (happens if two instances are opened) 2) Fix banner source setting to allow individually replacing banner or icon while using the other from repo. 3) Icon and banner text is now set back to red when changing game type modes. 4) Correct text for boot logo not specified which would previously get set to 'Gamepad Banner not specified' 5) Corrected the behavior of many advanced options that were not enabling/disabling in all transition possibilities.

Some of the big non-bug changes: 1) Added libTGA to reduce external tools dependencies 2) Moved all advanced option UI labels into panels for future cleanup/streamlining 3) AnCast Key entry/button only appears now when the c2w option is selected.