pirelenito / git-revision-webpack-plugin

🏗 Webpack plugin that generates VERSION and COMMITHASH files during build
https://www.npmjs.com/package/git-revision-webpack-plugin
MIT License
358 stars 48 forks source link

Added support for an output path prefix option. #20

Closed ezzatron closed 6 years ago

ezzatron commented 6 years ago

At my workplace, we use Webpack to produce "branded", or "skinned" applications, which dictates that we have a directory structure like so:

root/            # (webpack output directory)
  ├ common/      # (common assets)
  │ ├ BRANCH
  │ ├ COMMITHASH
  │ ├ VERSION
  │ └ ...
  └ site/
    ├ site-a/    # (assets specific to "site-a")
    │ └ ...
    └ site-b/    # (assets specific to "site-b")
      └ ...

This PR adds support for a path option, which allows us to output the version files in a location that works with our directory structure.

pirelenito commented 6 years ago

Thanks for the great PR!

I'll be reviewing this hopefully the next day or so.

pirelenito commented 6 years ago

Hi @ezzatron,

I'll be closing this PR due to innactivity, but please feel free to open again if you wish to have the functionality in.

Cheers!