search

pirelenito / git-revision-webpack-plugin

🏗 Webpack plugin that generates VERSION and COMMITHASH files during build
https://www.npmjs.com/package/git-revision-webpack-plugin
MIT License
358 stars 48 forks source link

Implement LASTCOMMITDATETIME #36

Closed tartinesKiller closed 5 years ago

tartinesKiller commented 6 years ago

Including docs and tests.

bencoveney commented 5 years ago

I am in no way a maintainer but FWIW I've taken a look and the only think I'd mention is that when adding the branch info it was requested to be behind a flag:

We should keep the branch file creation behind a flag (branch: true) so that we can release it as a minor version. It should have the default value as false.

Thanks for the feature (and thanks to the maintainers) - This change would be super useful for me.

pirelenito commented 5 years ago

Thanks for the PR @tartinesKiller, and thanks @bencoveney for the review.

Indeed it looks great! As I mentioned in #46 I'll be doing some housekeeping soon in this project and hopefully get your PR merged.

One year is way too long time to wait. So I'm sorry for that.

Thanks a bunch for your understanding. ❤️