Fix issue with filename functions

pirelenito / git-revision-webpack-plugin

🏗 Webpack plugin that generates VERSION and COMMITHASH files during build

https://www.npmjs.com/package/git-revision-webpack-plugin

MIT License

358 stars 48 forks source link

Fix issue with filename functions #42

Closed njbmartin closed 5 years ago

njbmartin commented 5 years ago

Fixes #39

Not sure which plugin has caused the issue but this resolves the compatibility.

ViktorAksionov commented 5 years ago

Any plans to merge it?

swarthy commented 5 years ago

Related webpack-contrib/mini-css-extract-plugin/issues/417

pmeinhardt commented 5 years ago

I'm getting the same error after upgrading webpack and webpack-related packages in a project. Would love to see it fixed, so I can continue using this great plugin @pirelenito 💚

pirelenito commented 5 years ago

Hi,

Thank you all for understanding this long delay on getting back to you. I'll merge this and get a patch released ASAP.

@njbmartin do you think it would be possible to do a followup PR with a test covering this issue?

Cheers! ❤️

pirelenito commented 5 years ago

Just released 3.0.4 with your fix included. ✋