search

pirelenito / git-revision-webpack-plugin

🏗 Webpack plugin that generates VERSION and COMMITHASH files during build
https://www.npmjs.com/package/git-revision-webpack-plugin
MIT License
358 stars 48 forks source link

Plugin doesn't create files #44

Closed Boscop closed 3 years ago

Boscop commented 5 years ago

I'm using the plugin as described in the Readme, but it's not creating any files. The project is built inside docker, using webpack@4.31.0 and webpack-cli@3.3.2. But the plugin seems to be calling git, because when git is not installed inside docker, it fails with Error: Command failed: git rev-parse HEAD /bin/sh: 1: git: not found. So after installing git inside docker, it's not failing and not giving any error, so it's calling git but not writing these files for some reason. Any idea why?

dimaqq commented 4 years ago

A random thought about what could be going on: How do you get the source code into the docker container? It's common to COPY stuff in without the .git directory, in which case there's no information about branches, git hashes, etc. inside the container.

toddwong commented 4 years ago

Seems you haven't installed git in your system?

pirelenito commented 3 years ago

Closing for lack of activity.