pires / docker-elasticsearch

Dockerfile for a base Elasticsearch image to be extended by others (allow to install plug-ins, change configuration, etc.)
Apache License 2.0
161 stars 173 forks source link

Add patched jvm.options file which removes -Xmx and -Xms lines #27

Closed VSpike closed 7 years ago

VSpike commented 7 years ago

The /elasticsearch/bin/elasticsearch script in the container contains this text:-

# Optionally, exact memory values can be set using the `ES_JAVA_OPTS`.
# Note that the Xms and Xmx lines in the JVM options file must be
# commented out. Sample format include "512m", and "10g".

Supplying -Xmx and -Xms in ES_JAVA_OPTS when the lines are still in the $ES_HOME/config/jvm.options causes the -Xmx and -Xms settings to be specified twice on the process command line. I'm not certain what effect this has, but it's clearly not desirable!

There seemed to be three ways to fix this:-

In the end I went for the second option, and copied the jvm.options out of the ES package and then commented out the offending lines.

pires commented 7 years ago

@VSpike the commit is not properly authored. Fix, push -f and ping me.

VSpike commented 7 years ago

@pires is that OK now?

pires commented 7 years ago

👍 thanks