search

pires / docker-elasticsearch

Dockerfile for a base Elasticsearch image to be extended by others (allow to install plug-ins, change configuration, etc.)
Apache License 2.0
161 stars 173 forks source link

Properly fixing #70 #73

Closed nick-pap closed 6 years ago

nick-pap commented 6 years ago

This fixes the find command to properly scan only for files not having elasticsearch user in specific folders

pires commented 6 years ago

Hello @dn0! As the bug reporter, can you please review?

dn0 commented 6 years ago

Btw. What is the motivation behind this? I understand that before starting a fresh node it is needed. But for restarts and upgrades I don't see the benefit.

Maybe we could go back to chown -R, but only when started for the first time, e.g.:

if [ ! -d /data/data/nodes ]; then
    chown -R elasticsearch:elasticsearch /data
fi

And the ownership of the /elasticsearch ($BASE) folder and subfolder could be handled in the Dockerfile during build time.

pires commented 6 years ago

@dn0 why don't you own a PR that addresses all of this properly? I'd like to include it as part of 6.4.2.

dn0 commented 6 years ago

@pires @nick-pap https://github.com/pires/docker-elasticsearch/pull/75