Closed unmarshal closed 3 years ago
I'm under the impression I'm about to learn something here but how can the coverage increase if no tests were implemented? Are the examples added here considered example tests?
I was scratching my head about the test coverage too. I ended up just removing the examples and moving the https server to the README. I didn't want to restructure your project.
No, no, no, please, keep the code in the examples
folder or let's make sure they are testable examples which is so much better than keeping examples in README.md. I am just curious how the hell goveralls reports a 0.7% increment in code coverage 😂
Sounds good. Will do.
code coverage didn't increase because of the examples. guessing it has to do with the new lines added when the deadline is set.
Whoops. Yes, that was a mistake. I will fix that and also add a test. Cheers.
Sorry about the premature squashing and force pushes. Didn't realize it messed with github's review system.
@pires I strongly urge you to pick a suitable default for when no read timeout is set. Otherwise you put the onus on library users to know that they have to do this in order to be safe.
Agreed.
Set a read deadline when waiting for the PROXY protocol header.