Closed pires closed 3 years ago
From my somewhat limited testing it still breaks off the connection with version github.com/pires/go-proxyproto@v0.6.1-0.20210713120647-bab7dd263f97
in my go.mod
although I cannot quite explain why :man_shrugging: .
Well, I think the testcase I implemented proves that the code in master fails and later passes with this PR so I'm out of ideas on what the issue may be for you.
I will be back in town next week. I will take a look first thing.
Thanks
On Thu, Jul 15, 2021 at 04:53 Pires @.***> wrote:
Well, I think the testcase I implemented prove that the code in master fails and passes with this PR so I'm out of ideas on what the issue may be for you.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pires/go-proxyproto/pull/76#issuecomment-880597094, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAD5RCGK3NCGXUPDN6L2NDTX24ZLANCNFSM5AI6Q4LA .
-- Sent from Gmail Mobile
@unmarshal any chance you'll be able to take a look into this soon?
@antoniomika thanks for the comment. I need to take an hour to think this through and your feedback is definitely appreciated.
@antoniomika's change looks correct to me.
@unmarshal are you sure? Please, read this https://github.com/pires/go-proxyproto/pull/76/files#r694345619
Thank you all very much for reporting the issue, the discussion on how to address and the code. I'm happy to have you all around 🙇🏻
The fix was released as https://github.com/pires/go-proxyproto/releases/tag/v0.6.1
Can you, please, help review @unmarshal, as it is related to your PR #74?
Fixes #75