Closed antoniomika closed 3 years ago
I'll have to think about this and this week I'm already packed. Thanks @antoniomika
Hi,
I just tested this patch with SFTPGo for proxy SSH and FTP connections, it looks fine. Are there any blockers to merge it? thanks
Hey @pires,
Added some more documentation, cleaned up some unneeded boilerplate and we should be ready to go!
Best,
@pires just a heads up, this should merge first, followed by #76 after this lands.
@pires just a heads up, this should merge first, followed by #76 after this lands.
What is there in #76 that isn't solved here?
@pires just a heads up, this should merge first, followed by #76 after this lands.
What is there in #76 that isn't solved here?
To apply this patch you have to apply #76 first.
@pires just a heads up, this should merge first, followed by #76 after this lands.
What is there in #76 that isn't solved here?
To apply this patch you have to apply #76 first.
Damn, I must have that espresso urgently! 😅
Somehow #82 landed here and I'd like to give the chance for @drakkan to get their contribution in. Can you please remove this?
Sorry about that, I should've checked if there was another PR with the static check fixes. I use code spaces and was a bit OCD with the linting issues. I actually started working on #73 but those changes were more complicated so I decided to leave them for when I had more time. You can remove those changes in your PR now and merge in #82.
Yeah #73 is painful. Also have a branch for a long while now 😅
edited by @pires
Fixes #75