Closed igor-kupczynski closed 3 years ago
I've noticed a naming inconsistency and force-pushed a fixed version. Hope that OK -- my thinking was that a simple rename doesn't add a lot to the history.
Nice, thanks for merging :) and thanks for maintaining the library.
func names tied to PP2 type, eg
PP2GCP.ExtractPSCConnectionID
, or maybe havetlvparse/{aws,azure,gcp}
Agree, it would be nice to improve the consistency here. I'll think about it for a bit.
Given that we already have AWS, and Azure in
tlvparse
I thought it will be a good idea to add the GCP support as well.We use it with GCP in our pre-prod env and all seems to be working well.
Let me know if you think it makes sense to have this with the upstream lib.