search

pires / go-proxyproto

A Go library implementation of the PROXY protocol, versions 1 and 2.
Apache License 2.0
478 stars 107 forks source link

Bump DefaultReadHeaderTimeout to 10s #84

Closed emersion closed 2 years ago

emersion commented 2 years ago

When dealing with slow networks and TLS, 200ms is often hit. Bump the default timeout to 10s, which is what crupto/tls uses for the TLS handshake.

Closes: https://github.com/pires/go-proxyproto/issues/83

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 95.543% when pulling 7f1f93d48c7d043027e2778f6d7ccbb646049df1 on emersion:default-timeout into 2e44d7a76a851d66890ab341403253afae5caac2 on pires:main.

emersion commented 2 years ago

Gentle ping

pires commented 2 years ago

Sorry @emersion in between work and sickness, I just haven't been able to look into this. Thanks a lot for your contribution, once more!