search

pires / kubernetes-elasticsearch-cluster

Elasticsearch cluster on top of Kubernetes made easy.
Apache License 2.0
1.51k stars 690 forks source link

Stateful masters #2 #219

Closed skokovic closed 6 years ago

skokovic commented 6 years ago

Hey Paulo! @pires

After merging stateful masters branch, you removed services for StatefulSets which I think are still needed for the network to work properly. These services are referenced via spec.serviceName in StatefulSet Controller.

Ref: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#limitations "StatefulSets currently require a Headless Service to be responsible for the network identity of the Pods. You are responsible for creating this Service."

I've added es-data-svc.yaml and es-master-svc.yaml as a part of stateful cluster deployment.

Sorry for forgetting it in the first PR

pires commented 6 years ago

The PR has conflicts.

skokovic commented 6 years ago

Resolved.

Github doesn't take es-data-svc.yaml as a change even though I have it in this branch and that file is deleted on your master branch, so I'm not sure if you see in what state es-data-stateful.yaml and es-data-svc.yaml need to be.