Update PendingTroubleCodesCommand.java

pires / obd-java-api

OBD-II Java API

Apache License 2.0

599 stars 297 forks source link

Update PendingTroubleCodesCommand.java #107

Closed Pho3niX90 closed 8 years ago

Pho3niX90 commented 8 years ago

Quick fix to resolve following error: rawData: 43010301030000 Exception: length=14; regionStart=13; regionLength=3

pires commented 8 years ago

@Pho3niX90 this breaks tests. Care to fix?

Pho3niX90 commented 8 years ago

@pires yes I saw. Let me do some more debugging. I am not convinced this class yields accurate results. I am getting codes that aren't stored (test system). In fact theres no codes but returning 3.

Pho3niX90 commented 8 years ago

Should be fixed now. My test also proves fruitful

pires commented 8 years ago

Care to squash your commits into one?

Pho3niX90 commented 8 years ago

@pires I made the changes via browser. I am not sure if there is a way to rebase via web interface?

pires commented 8 years ago

No there is not. Still #108 blocks this PR from being merged, right?

Pho3niX90 commented 8 years ago

Yes. Hold for the other change

pires commented 8 years ago

Ready to merge? I will squash the commits and edit the commit message.

Pho3niX90 commented 8 years ago

Yes please.