search

pires / obd-java-api

OBD-II Java API
Apache License 2.0
595 stars 295 forks source link

Extra algorithm to support VINs returning special chars #112

Closed Pho3niX90 closed 8 years ago

Pho3niX90 commented 8 years ago

Extra tests: http://goo.gl/QuLlY6 Possible fix for: https://github.com/pires/android-obd-reader/issues/174

pires commented 8 years ago

Why don't you add a test for this as well?

Pho3niX90 commented 8 years ago

I think that is a good idea. But do not merge yet please. As it has not solved the users issue

Pho3niX90 commented 8 years ago

Okay this did manage to solve my issue and the users issue #174. I just want to simplify the code and try and add additional test case.