%DESCRIPTION% not working

DavidMcRitchie commented 4 years ago

Short description

Was failing with error codes now have a mixture of returning nothing or error codes

Steps to reproduce

Test1 %URL%

https://mail.aol.com/webmail-std/en-us/suite https://github.com/piroor/copy-selected-tabs-to-clipboard/labels view-source:https://github.com/piroor/copy-selected-tabs-to-clipboard/labels about:addons

Test2 %description%123%DESCRIPTION%345%TITLE%678%EOF%

123345AOL Mail (5333)678%EOF% 123345Issues · piroor/copy-selected-tabs-to-clipboard · GitHub678%EOF% 123345https://github.com/piroor/copy-selected-tabs-to-clipboard/labels678%EOF% 123345Add-ons Manager678%EOF%\

HTML Link with Description %TITLE_HTML%

and added another tab and retested http://dmcritchie.mvps.org/dolphin/lesson_from_newtab.htm

params.tab is undefined fillPlaceHoldersInternal@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:221:1 fillPlaceHolders@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:188:44

Issues · piroor/copy-selected-tabs-to-clipboard · GitHub https://github.com/piroor/copy-selected-tabs-to-clipboard/labels Add-ons Manager params.tab is undefined fillPlaceHoldersInternal@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:221:1 fillPlaceHolders@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:188:44

Expected result

A good link to go into an HTML file or to paste into an RTF document

Bookmarklets, history, exported bookmarks, extensions for Chrome (2020-07-25)

Actual result

Results shown above

Environment

Platform (OS): Windows 10 on ASUS T100TA
Version of Firefox: 78.0.2 *Version of Copy Selected Tabs to Clipboard: 1.3.0
Version (or revision) of Multiple Tab Handler: didn't see requirement for MTH (not installed), Enabled 3.1.3

Results still the same)

params.tab is undefined fillPlaceHoldersInternal@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:221:1 fillPlaceHolders@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:188:44

https://github.com/piroor/copy-selected-tabs-to-clipboard/labels Add-ons Manager params.tab is undefined fillPlaceHoldersInternal@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:221:1 fillPlaceHolders@moz-extension://c8319d8c-7857-437d-aa04-f6621a670f5b/common/commands.js:188:44

piroor commented 4 years ago

Thanks! The commit df63426 should fix this.

DavidMcRitchie commented 4 years ago

Thanks Piro, just came back to try to make the pattern show up better and it is already solved/closed.

Love the tools for keeping track of changes in github (like archive.org, and wikipedia.org), and the fix shows me how shortened words are official as the examples didn't exactly match definitions.

The whole process is a lot better than using email or newsgroup as we had done before.

piroor / copy-selected-tabs-to-clipboard