search

piroor / copy-selected-tabs-to-clipboard

Provides ability to copy title and URL of selected tabs to the clipboard for Firefox 63 and later.
Other
79 stars 16 forks source link

[Feature Request] Don't use a submenu if only one format is enabled #7

Closed FatOrangutan closed 4 years ago

FatOrangutan commented 4 years ago

Short description

It would be great if the submenu could be avoided if only one format is enabled in the Options page, so that the actionable menuitem can be present in the root menu itself.

Steps to reproduce

  1. Start Firefox with a clean profile.
  2. Install the add-on.
  3. Go to its Options and remove all but one formats

Expected result

There is only one format enabled, hence it shouldn't be behind a submenu.

Actual result

It is behind a submenu.

Capture

Environment

piroor commented 4 years ago

I've implemented this together with #8. Thanks again!

FatOrangutan commented 4 years ago

Thanks a lot! One little issue I noticed: it seems that this menuitem doesn't respect the 'Show context menu item in the context menu on the content area' setting. So STR:

1) In the Options page, uncheck all but one formats 2) Uncheck 'Show context menu item in the context menu on the content area' 3) Click empty area on some page

AR: Capture

piroor commented 4 years ago

Thanks! The regression has been fixed with the commit a641d04.