search

piroor / informationaltab

Informational Tab, Provides thumbnail, progress meter, or others to each tab.
http://piro.sakura.ne.jp/xul/informationaltab/
4 stars 5 forks source link

Set real minimum thumbnail size in options dialog #3

Closed Infocatcher closed 11 years ago

Infocatcher commented 12 years ago

I think, we can do it without try/catch – it's safe to get error here.

piroor commented 11 years ago

Oh, thanks! I missed this request.

piroor commented 11 years ago

Oops, I misread... The text box is just for "maximum size of flexible thumbnail", not for "minimum". I've reverted it...

Infocatcher commented 11 years ago

Oops, I misread... The text box is just for "maximum size of flexible thumbnail", not for "minimum". I've reverted it...

Hmm... this is .setAttribute('min', thumbnailMinSize). Anyway, the real reason is hardcoded minimum thumbnail size: we can set anything in options, but will be used only 26px and larger. So, #4 is also related to this issue.

piroor commented 11 years ago

OK, sorry, I reintroduced this patch! I've been haste...