piroor / multipletab

Multiple Tab Handler, Provides feature to close multiple tabs.
http://piro.sakura.ne.jp/xul/multipletab/
Other
81 stars 23 forks source link

Whitespace around ampersand in messages.json disappears #195

Closed ConorAAG closed 6 years ago

ConorAAG commented 6 years ago

Short description

When right-clicking on tab selection any menu item label containing ampersand that is immediately preceded/followed by a whitespace, has that whitespace stripped out. e.g. "Move Tabs to New &Window" is show in browser as "Move Tabs to NewWindow"

Steps to reproduce

  1. Start Firefox with clean profile.
  2. Install MTH.
  3. Open at least one tab
  4. Click on MTH icon
  5. Select tab and right-click on the tab entry
  6. View menu item labels. White space is missing in certain entries. In each case the missing white space is either immediately preceded or followed by an ampersand in the messages.json locale file.

Expected result

Actual result

multitaberrorlocale

See above image for issue. Effected labels are:

Move to NewWindow CopyTo Clipboard SelectAll

Environment

P.S. you have a typo in template for this page!!

strucutre => structure

piroor commented 6 years ago

After I inspected, I've confirmed that there is actually a space as: Move Tabs to New <span class="accesskey">W</span>indow. So, it seems to be collapsed by something CSS rule. And finally I've realized that diplay:flex causes this problem and it should be fixed by the commit ed97742. Thanks!

ConorAAG commented 6 years ago

Good stuff!