search

piroor / multipletab

Multiple Tab Handler, Provides feature to close multiple tabs.
http://piro.sakura.ne.jp/xul/multipletab/
Other
81 stars 23 forks source link

Changes to the list of "Copy to Clipboard" formats don't get saved #213

Closed ssokolow closed 4 years ago

ssokolow commented 6 years ago

Steps to reproduce

  1. Start Firefox with clean profile.
  2. Install MTH.
  3. Grant "Copy to Clipboard" permissions
  4. Attempt to add a new format to Copy to Clipboard's submenu

Expected result

The items should appear in the Copy to Clipboard submenu.

Actual result

The submenu remains unchanged and the changes in the Preferences page may or may not have reverted themselves.

I was forced to enable debug mode and manually edit the contents of copyToClipboardFormats to get the changes to stick.

Here is the setup I wound up with:

[{"label":"URI","format":"%URL%"},{"label":"Title and URI","format":"%TITLE%%EOL%%URL%"},{"label":"HTML Link","format":"<a title=\"%TITLE_HTML%\" href=\"%URL_HTML%\">%TITLE_HTML%</a>"},{"label":"Markdown","format":"[%TITLE%](%URL% \"%TITLE%\")"},{"label":"Markdown (List)","format":"%TST_INDENT(  )%* [%TITLE%](%URL% \"%TITLE%\")"},{"label":"TiddlyWiki","format":"[[%TITLE%|%URL%]]"},{"label":"TiddlyWiki (List)","format":"%TST_INDENT(*)%* [[%TITLE%|%URL%]]"},{"label":"reStructuredText (List)","format":"%TST_INDENT(  )%-  `%TITLE% <%URL%>`__"}]

I added the "reStructuredText" option this time. "TiddlyWiki" and "TiddlyWiki (List)" were already there from the changes I made when I first installed Multiple Tab Handler.

The problem manifested in both of these test cases:

  1. Attempting to add the "reStructuredText" line below "TiddlyWiki (List)" on my day-to-day Firefox Developer Edition profile.
  2. Attempting to add the "TiddlyWiki" line below "Markdown (List)" on a brand new install of MTH in a fresh Firefox Nightly profile.

Environment

vonHabsi commented 5 years ago

Same here.

It is a good thing I found this issue, I will be able to add Asciidoctor too

piroor commented 5 years ago

Thanks! The commit c0596d9 should fix this problem.

vonHabsi commented 5 years ago

I have checked this one as well and it is working fine.

Thanks again.