search

piroor / multipletab

Multiple Tab Handler, Provides feature to close multiple tabs.
http://piro.sakura.ne.jp/xul/multipletab/
Other
81 stars 23 forks source link

Addon fails to copy all tabs #217

Closed vonHabsi closed 5 years ago

vonHabsi commented 5 years ago

Short description

When you multiselect a whole tabtree, and apply the Copy Tabs to Clipboard menu not all the tabs are copied,

Steps to reproduce

  1. Start Firefox with clean profile.
  2. Install MTH.
  3. Enable permissions for Copying tabs to clipboard
  4. Open a lot of tabs, say more than 20 in a subtree
    1. Click on the parent tab, making sure it is collapsed to ensure children are automatically selected even if they are hidden, and right click and choose Copy To Clipboard and the required format.

Expected result

The whole list should be copied

Actual result

Most of the time less than 15 are copied even if there are a lot more.

Environment

piroor commented 5 years ago

I couldn't reproduce this problem with large number direct children tabs, but I reproduced similar problem with mixed collapsed/expanded subtree, like:

In this case, I ctrl-click the tab "1" then only "1-1", "1-2", "1-2-1", and "1-2-2". "1-1-1" and "1-1-2" are not selected because "1-1" is detected as an expanded tree. By recent commits I changed the behavior to select all descendants of the clicked tab "1" as expacted. Is this same to the problem you saw?

vonHabsi commented 5 years ago

I haven't been actually checking the collapsed state of all the tabs, and to checking which ones have actually been copied and which ones have been missed.

To simplify matters I collapse the parent tab of the whole tree and count the total number of child tabs.

I then copy it into a text editor and check the number of lines copied to see if matches the child tab count.

On coming to see your response, I tested a parent tree with 397 children, grandchildren, etc and they were all copied.

I have also tested it in other profiles and I would say the problem is fixed now.

Thanks a lot.

vonHabsi commented 5 years ago

I just noticed this issue in my list and want you to know that it is okay to close it. It was fixed back then, but I think it is irrelevant now with the changes made since then.

Thanks