Command-click does not unselect after Invert selection

piroor / multipletab

Multiple Tab Handler, Provides feature to close multiple tabs.

http://piro.sakura.ne.jp/xul/multipletab/

Other

81 stars 23 forks source link

Command-click does not unselect after Invert selection #227

Closed joshgold22 closed 4 years ago

joshgold22 commented 4 years ago

Command click (on mac, control-click on others) should toggle tab selection, but it only selects. It does not unselect a tab that was selected.

Environment

Platform (OS): OSX 10.12
Version of Firefox: 69.0.2
Version (or revision) of Multiple Tab Handler: 3.0.10 (2019.8.8) / TST 3.1.8 (2019.9.13)

joshgold22 commented 4 years ago

I learned more about this. In typical circumstances, command click does properly unselect the selected tab. The problem occurs after Invert selection. If you select some tabs, Invert selection, and then command click a tab, it undoes the invert selection, going back to what was selected before (and has no special effect on the tab you command-clicked)

piroor commented 4 years ago

Thanks! I forgot to handle the command key. With recent commits command-click looks to toggle selection state in the popup panel for me. Could you try the development build with the about:debugging?