search

piroor / secondsearch

Second Search, Shows tiny popup for the search bar, to allow you to search by another engine quickly.
http://piro.sakura.ne.jp/xul/secondsearch/
Other
8 stars 2 forks source link

Open search in tab controls #1

Open Jorlem opened 13 years ago

Jorlem commented 13 years ago

Second Search's options only allow a search to open in the current tab, or in a new tab, but not both options at the same time. Firefox's default behavior, without Second Search installed, is to open a search in the current window if the 'magnifying glass' search icon is clicked with the left mouse button, and to open the search in a new tab if the search icon is clicked using the mouse wheel, or whatever button is assigned to open a link in a new tab. Second Search overrides this behavior, and forces the search to open by whatever tab preference is selected in Second Search's options menu, no matter which mouse button is used.

Would it be possible to have an option to allow Firefox's default behavior to carry through the extension, instead of having it be overridden by the preference selected in the options menu?

piroor commented 13 years ago

If Tab Mix Plus is installed, the problem happens. Both TMP and Session Store use the preference "browser.search.openintab" to store the configuration. I think this is a bug of TMP.

Anyway, Second Search didn't handle the magnifier button so I've add codes for it. In the next release you'll be able to switch the behavior of the button by left/middle buttons. https://github.com/piroor/secondsearch/commit/3cb348bdcecb3b14f54807a487dce98fb7e10394

Jorlem commented 13 years ago

When you say next release, is that the release that came out today, or will it not be until next time?
Thanks for all this, by the way.

piroor commented 13 years ago

I've released 0.6.2011052802 and it includes the commit above.

Jorlem commented 13 years ago

OK, thanks. I have it set to open search results into a new tab, so when I left click, it opens in a new tab, and when I middle click, it does the search in the same tab that I have open already. It's a little unintuitive at first, but it does both things, so thank you very much. :)

vanowm commented 8 years ago

As of 0.9.2015020901 the problem is not solved. Also, new tab should be opened when holding ALT key.

vanowm commented 8 years ago

This issue is not related to TabMixPlus, still reproducible without TMP installed in v1.0.2016020401 Holding ALT key or pressing middle mouse button has no effect, it opens search result in current tab.