piroor / treestyletab

Tree Style Tab, Show tabs like a tree.
http://piro.sakura.ne.jp/xul/treestyletab/
Other
3.5k stars 278 forks source link

New Tab open and closes #2162

Closed rdewolff closed 5 years ago

rdewolff commented 5 years ago

I have found an issue reported to Connex : https://github.com/kesselborn/conex/issues/303

But am not sure who is responsible for the bug. Just posting here to cross link if needed.

rdewolff commented 5 years ago

The issue has been updated on conex, and @piroor has commented the following :

After testing I've realized why this happens on a case. https://github.com/kesselborn/conex/blob/master/conex-background.js#L467 Conex tries to open a new tab as a "child" of the original tab, and immediately closes the "parent" tab after the child is opened. On the other hand, TST automatically attaches the new "child" tab to the "parent", but its tree is internally still collapsed. Because the "parent" tab is closed before it becomes expanded, TST closes all children in the collapsed tree.

I think this problem must be fixed by TST side.

Could any of the dev here have a look at this issue? Would be great!

piroor commented 5 years ago

The commit 2233374 should fix this.

piroor commented 5 years ago

I close this because outdated.