Sidebar does not open fully on mouse hover

hwair commented 4 years ago

Short description

Hovering the mouse over the collapsed sidebar does not open it. Clicking on tabs still works.

Steps to reproduce

Open Firefox
Install fresh TST

Use the following config:

{
"applyBrowserTheme": false,
"applyThemeColorToIcon": true,
"autoAttachSameSiteOrphan": 0,
"autoCollapseExpandSubtreeOnAttach": false,
"autoCollapseExpandSubtreeOnSelect": false,
"autoGroupNewTabs": false,
"cachedExternalAddons": [
"{c2c003ee-bd69-42a2-b0e9-6f34222cb046}"
],
"closeParentBehavior": 6,
"closeParentBehaviorMode": 1,
"configsVersion": 8,
"context_expandTree": true,
"labelOverflowStyle": "crop",
"lastConfirmedToCloseTabs": 1570907497537,
"longPressOnNewTabButton": "newtab-action-selector",
"migratedBookmarkUrls": [
"moz-extension://477cb14e-5b6d-424f-990c-434d8b526aef/resources/group-tab.html",
"moz-extension://477cb14e-5b6d-424f-990c-434d8b526aef/options/options.html",
"moz-extension://477cb14e-5b6d-424f-990c-434d8b526aef/resources/startup.html",
"moz-extension://477cb14e-5b6d-424f-990c-434d8b526aef/tests/runner.html"
],
"notifiedFeaturesVersion": 4,
"optionsExpandedSections": [
"section-appearance",
"section-advanced",
"section-contextMenu",
"section-newTab",
"section-treeBehavior",
"section-shortcuts",
"section-addons",
"section-debug"
],
"scrollbarMode": 0,
"showContextualIdentitiesSelector": true,
"style": "vertigo",
"userStyleRules": "* {\n  color: black !important;\n}\n\n.tab {\n  border: solid 2px #85929e;\n  border-left-width: 2px !important;\n  border-right-width: 0px;\n  margin-bottom: -2px;\n}\n/* As little space before the tab name as possible.\n   The fold/unfold icon is not affected. */\n.tab:not(.pinned) {\n  padding-left: 0px !important; /* !important is required when there are enough tabs to cause a scrollbar */\n}\n/* Change styling of the favicon of pending (unloaded) tabs */\n.tab.discarded .favicon {\n  opacity: 1 !important;\n}\n.tab .closebox::before {\n  border-radius: 10px; /* vary between 0 and 10 to make the background rounder */\n}\n/* I find these work well on my monitor (slightly darker than the normal tab color) but YMMV */\n.tab .closebox:hover::before {\n  background: #ec7063;\n  opacity: 1; /* defaults to 0.1 */\n}\n.tab.active .closebox:hover::before {\n  background: #ec7063;\n}\n/* Hide border on tab bar, force its state to 'scroll', adjust margin-left for width of scrollbar. */ \n#tabbar { border: 0; overflow-y: scroll !important; margin-left: -18px !important; }\n\n/* Hide .twisty and adjust margins so favicons have 7px on left. */\n.tab .twisty {\n    visibility: hidden;\n    margin-left: -6px;\n}\n\n.tab:hover .twisty {\n    visibility: initial;\n    margin-left: 5px;\n}\n\n/* Push tab labels slightly to the right so they're completely hidden in collapsed state */\n.tab .label {\n    margin-left: 7px;\n}\n\n/* Hide close buttons on tabs. */\n.tab .closebox {\n    visibility: collapse;\n}\n\n.tab:hover .closebox {\n    visibility: initial;\n}\n\n/* Hide sound playing/muted button. */\n.sound-button::before {\n    display: none !important;\n}\n\n/* ################################################ */\n/* ##### COLOR THEME ############################## */\n/* ################################################ */\n\n:root {\n    background-color: #383838;\n}\n#tabbar {\n    box-shadow: none !important;\n}\n.tab {\n    box-shadow: none !important;\n}\n.tab.active {\n   background-color: #85c1e9bb;\n}\n.tab.active:hover {\n   background-color: #5dade2bb;\n}\n.tab:hover {\n   background-color: #76d7c4bb;\n}\n\n/* Adjust style for tab that has sound playing. */\n.tab.sound-playing .favicon::after {\n    content: '';\n    position: absolute;\n    top: 50%;\n    left: 50%;\n    border-radius: 50%;\n    background: #ffffff;\n    animation: pulse 2s ease-out 0s infinite;\n    z-index: -1;\n    opacity: 0;\n}\n\n/* Adjust style for tab that is muted. */\n.tab.muted {\n    opacity: 0.5;\n}\n\n/* Better alignment of Favicons when collapsed */\n.tab[data-level][data-level=\"0\"] {\n  margin-left: 2% !important;\n}\n.tab[data-level][data-level=\"1\"] {\n  margin-left: 4% !important;\n}\n.tab[data-level][data-level=\"2\"] {\n  margin-left: 6% !important;\n}\n.tab[data-level][data-level=\"3\"] {\n  margin-left: 8% !important;\n}\n.tab[data-level][data-level=\"4\"] {\n  margin-left: 10% !important;\n}\n.tab[data-level][data-level=\"5\"] {\n  margin-left: 12% !important;\n}\n.tab[data-level][data-level=\"6\"] {\n  margin-left: 14% !important;\n}\n.tab[data-level][data-level=\"6\"] {\n  margin-left: 16% !important;\n}\n.newtab-button-box {\n  position: fixed;\n  top: 7px;\n  left: 2px;\n  right: 0;\n  height: 20px;\n}\n#tabbar {\n  top: 30px !important;\n  bottom: 0 !important;\n  background-color: #f4f6f7 !important;\n}\n.tab.pinned {\n  margin-top: 20px;\n}\n\n\n/* regular width scrollbar */\n#tabbar { scrollbar-width: auto; }",
"workaroundForBug1548949DroppedTabs": "1582083123693-55001/16"
}

Expected result

Tree opens and stays open

Actual result

Tree doesn't open at all, only some slight shifting is seen bug.mp4.zip As seen in the video, clicking on tabs to navigate works just fine

Environment

Platform (OS): Linux Mint
Version of Firefox: 73.0.1
Version (or revision) of Tree Style Tab: 3.3.6

hwair commented 4 years ago

Note: the issue appeared right after I updated my Firefox. The last time I updated was over 2 months ago though, so I am unsure what version it was previously.

hwair commented 4 years ago

Still doesn't work in 3.4.1, if that helps

irvinm commented 4 years ago

@xXQWERTXx, how are you trying to do handle the sidebar collapsing\expanding? I assume you are doing it via userChrome.css? (Ex: https://www.reddit.com/r/FirefoxCSS/comments/7459ws/autohide_sidebar_for_tree_style_tab/)

I am not sure this necessarily has anything to do with TST itself. I could be wrong here, but this might be a better question for https://www.reddit.com/r/FirefoxCSS/. It is certainly possible something changed with Firefox in terms of the CSS elements and you did mention this started when you upgraded Firefox.

hwair commented 4 years ago

Oh, that's a good point - I'll take a look there

hwair commented 4 years ago

Ok so I did what was said at https://www.reddit.com/r/FirefoxCSS/comments/e6x7vj/treestyletabs_with_collapse_not_opening_on_720b3/ The sidebar extends perfectly now, but now the issue is the x button on the tabs doesn't do anything when clicked.

irvinm commented 4 years ago

Glad you got collapse\extend working. As for the "x" button, please look over: https://github.com/piroor/treestyletab/issues/2501

Can you close this item? Thanks.

piroor / treestyletab