search

piroor / treestyletab

Tree Style Tab, Show tabs like a tree.
http://piro.sakura.ne.jp/xul/treestyletab/
Other
3.5k stars 278 forks source link

Firefox Alpenglow dark theme not respected #2915

Closed auscompgeek closed 4 days ago

auscompgeek commented 3 years ago

Short description

The standard Firefox chrome respects the OS color scheme (dark mode) when using the Firefox Alpenglow theme. TST will only show the Alpenglow light background regardless of active preferred color scheme.

Steps to reproduce

  1. Start Firefox with clean profile.
  2. Choose the Firefox Alpenglow theme.
  3. Ensure (prefers-color-scheme: dark) is set.
  4. Install TST.

Expected result

TST shows the dark purple background like the native sidebars.

Actual result

TST shows the light Alpenglow background.

Environment

piroor commented 3 years ago

This looks to be cause by restrictions of WebExtensions API. browser.theme.getCurrent() always returns colors and image URLs for the bright mode for Firefox Alpenglow, and it is impossible to know which colors and images to be used on the dark mode.

dmose commented 3 years ago

Any chance you could file a Bugzilla bug filed about this? (I implemented some of the Alpenglow pieces, and I'd love to see it be possible to use it more effectively).

piroor commented 3 years ago

This restriction looks to be tracked at the bug: 1542044 - browser.theme.getCurrent() & onUpdated should take in account dark_theme manifest field

dmose commented 3 years ago

Great; thanks!

auscompgeek commented 3 years ago

no, bad bot

github-actions[bot] commented 2 years ago

This issue has been labeled as "stale" due to no response by the reporter within 1 year (and 7 days after last commented by someone). And it will be closed automatically 14 days later if not responded.

auscompgeek commented 2 years ago

bonk

wagnerand commented 2 years ago

This is https://bugzilla.mozilla.org/show_bug.cgi?id=1786564

irvinm commented 2 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1786564 is listed as resolved in FF106. Does this resolve this issue?

auscompgeek commented 2 years ago

Looking at that bug, it seems to refer to the gradient background having disappeared in Firefox 105 beta builds. This issue is about the background not responding to the system dark theme. It should match the colour of the toolbar. Bug 1542044 is the correct bug to track.

github-actions[bot] commented 1 year ago

This issue has been labeled as "stale" due to no response by the reporter within 1 year (and 7 days after last commented by someone). And it will be closed automatically 14 days later if not responded.

auscompgeek commented 1 year ago

This is still relevant 😞

piroor commented 1 year ago

This issues tracker currently aims to track issues which can (and should) be fixed by TST. Firefox-side issues which can't be fixed by an addon (like WebExtensions API restriction) may be closed whether it still happens actually, otherwise this list of issues may be fullfilled with this kind issues...

github-actions[bot] commented 2 weeks ago

This issue has been labeled as "stale" due to no response by the reporter within 1 year (and 7 days after last commented by someone). And it will be closed automatically 14 days later if not responded.

github-actions[bot] commented 4 days ago

This issue has been closed due to no response within 14 days after labeled as "stale", 7 days after last reopened, and 7 days after last commented.

aaronliu0130 commented 3 days ago

i'm guessing nothing on TST would fix this?