search

piroor / treestyletab

Tree Style Tab, Show tabs like a tree.
http://piro.sakura.ne.jp/xul/treestyletab/
Other
3.48k stars 279 forks source link

[Bug] Private window bricked after 4.0.0/4.0.1 upgrade #3475

Closed psofiterol closed 5 months ago

psofiterol commented 6 months ago

Abstract

Steps to reproduce

  1. Start Firefox with clean profile.
  2. Install TST.
  3. Make sure version is 4.0.1
  4. Open a private widow and start opening tabs 123.0 (64-bit)
  5. Version (or revision) of Tree Style Tab: 4.0.1
psofiterol commented 6 months ago

Downgraded to 3.9.22 to temporarily fix this - worked as expected.

piroor commented 6 months ago

I cannot reproduce this, so there looks to be something missing steps to reproduce. Could you share exported configs of TST with me?

psofiterol commented 6 months ago

Hey :wave:

Full version (skipped the lines about it being a snap, sry) image

And the configs: configs-treestyletab@piro.sakura.ne.jp.json

SimonPilkington commented 6 months ago

I encountered this after first updating from 3.9.22 to 4.0.1 but after restarting the browser it was fixed.

ElhemEnohpi commented 6 months ago

I got the same thing, starting today, with the 4.0.1 release, on Mac Firefox 123.0.1. My browser was open during the update to 4.0.1 overnight, and in the morning a private window I had open had the appearance similar to the "actual result" screenshot above. It was also not possible to scroll the tab sidebar. It seems to be resolved by restarting Firefox. Other non-private windows were not affected.

I was able to save the private window first, using Tab Session Manager. At first, restoring it also gave the broken appearance, but after restarting Firefox, I could restore it successfully.

psofiterol commented 6 months ago

right, thanks a lot @SimonPilkington & @ElhemEnohpi, I can confirm that restarting Firefox (after upgrading back to 4.0.1) has indeed fixed this issue!

@piroor not sure if I should just mark the issue as closed given the nature of the fix, leaving it up to you :pray: (maybe good to leave it up for other ppl who might encounter this?)

piroor commented 6 months ago

Sadly I still cannot reproduce the problem after importing the config file https://github.com/piroor/treestyletab/issues/3475#issuecomment-1991299512 . I've seen user style sheet in the config but I couldn't find out any possible triggers. Hmm...

Anyway restarting may be a workaround as some people reported, if something data cached by Firefox triggers problems.

afontenot commented 6 months ago

I also saw this and it went away after a restart.

Actually before restarting I downgraded and upgraded several times between the last 3.X and 4.01, and reproduced the issue multiple times whenever I returned to 4.01.

I also have a user style sheet (very small, just reduces the height of the tab bars), but removing it didn't fix the issue, even with a new private window.

afontenot commented 6 months ago

So, this is interesting. Now that I've restarted the browser, I see the reverse. When I force a downgrade to 3.9.22, the bug resurfaces! It then goes away again when I upgrade to 4.X.

Was able to reproduce on both photon and proton (the only two I tested).

github-actions[bot] commented 5 months ago

This issue has been labeled as "stale" due to no response by the reporter within 1 month (and 7 days after last commented by someone). And it will be closed automatically 14 days later if not responded.

psofiterol commented 5 months ago

Closing this - the issue goes away after a Firefox restart.