search

piroor / treestyletab

Tree Style Tab, Show tabs like a tree.
http://piro.sakura.ne.jp/xul/treestyletab/
Other
3.48k stars 279 forks source link

[Bug] "High Contrast" Theme renders without tab button borders in 4.0.10 #3517

Closed jmbreuer closed 5 months ago

jmbreuer commented 6 months ago

Abstract

Updated version 4.0.10 changes "High Contrast" Tab rendering, omitting borders, resulting in a rendering I'm less capable to grasp at a glance.

Steps to reproduce

  1. Start Firefox with clean profile.
  2. Install TST.
  3. Open TST preferences
  4. Choose "High Contrast" Theme under Appearance

Expected result

A Tab Tree rendering resembling what's shown in the preview graphic, and/or as it used to be before 4.0.10. This seems to be a change/regression related to that release.

Actual result

The Tab Tree renders without borders around the individual Tabs, depending on background color it makes the tree very hard to understand at a glance and does not meet "High Contrast" requirements/expectations.

In Firefox: Firefox Tree snippet

In LibreWolf: LibreWolf Tree snippet

Environment

Additional Information

The Photon theme in 4.0.10 looks quite like what I'm looking for, but would need a higher-contrast color scheme (especially: strong color for active tab which will probably make inverted text appropriate). I've had a brief look at the advanced style options, but don't really know which of those to touch to get where I'd want. (I.e. I'm missing a cheat sheet correlating the style names to what tree elements they relate to.) For a workaround, I'd be happy about some direction in that regard.

piroor commented 6 months ago

Thanks, I've realized that CSS system color ButtonShadow is now same to ButtonFace on Firefox 124 on Windows 11. It is possibly a bug of Firefox itself - it should be different from ButtonFace, anyway I've pushed a change to set border-color more visible: ButtonText.

piroor commented 6 months ago

Here is a workaround until the change is released, please set user style sheet in TST options as:

:root {
  --tab-border: ButtonText;
}
piroor commented 5 months ago

There is a new report about too high contrast of the new border color: #3526 @jmbreuer Could you try the visibility of another color? I'll apply it for the next release if it is acceptable.

:root {
  --tab-border: GrayText;
}
github-actions[bot] commented 5 months ago

This issue has been closed due to no response within 14 days after labeled as "has-workaround", 7 days after last reopened, and 7 days after last commented.