piroor / treestyletab

Tree Style Tab, Show tabs like a tree.
http://piro.sakura.ne.jp/xul/treestyletab/
Other
3.48k stars 279 forks source link

[Enhancement] support pref "browser.tabs.cardPreview.enabled" #3560

Open bege10 opened 4 months ago

bege10 commented 4 months ago

Abstract

Firefox allows to change the view of tab tool tips to card view. Please, support this preference.

Steps to see the situation

  1. Change "browser.tabs.cardPreview.enabled" to "true"
  2. On horizontal tabs the tool tip changes to card view

Expected result

The tabs tool tips of TST also change the view

Actual (present) result

The tabs tool tips of TST don't change the view

Environment

piroor commented 4 months ago

Firefox does not allow WebExtensions addons to show arbitrary popup, so we only have three choices:

All possible plans have serious cons, so currently I'm negative to implement preview popup from these choices.

Waterfox Sidebar (it is an extended version of TST) supports preview popup with native appearance. Waterfox itself is currently based on Firefox 115, so you'll see preview popup for tabs sidebar after its base version is updated to 128.

bege10 commented 4 months ago

Do we talk about the same things? I don't mean the thumbnails. That is an option in the settings page of Firefox independent from the normal or card view of the tooltip. Because the tooltip without thumbnail looks the same with or without TST when the mentioned pref is set to false I thought it might be possible to have it look the same with and without TST with this pref set to true. Screenshot_348

piroor commented 4 months ago

Oh sorry I misunderstood that you meant both browser.tabs.cardPreview.enabled and browser.tabs.cardPreview.showThumbnails are true. I've realized that you meant browser.tabs.cardPreview.enabled=true and browser.tabs.cardPreview.showThumbnails=false case.

I've created mock images for A, B and C.

A: image

B: image

C: image

piroor commented 4 months ago

As those mocks described, such a rich popup has problems regardless it has a preview image or doesn't. This is the reason why I'm negative to simulate "browser.tabs.cardPreview.enabled" by TST.

bege10 commented 4 months ago

I wouldn't mind A without thumbnail but I understand your opinion. Am I correct that the normal tool tip in TST is from Firefox and not simulated by TST? And that Firefox changes the tool tips to card view only for the normal Firefox tabs? So the only way to have card view tool tips in TST is by simulating them with extra code?

And thank you for this valuable add-on!