search

piroor / treestyletab

Tree Style Tab, Show tabs like a tree.
http://piro.sakura.ne.jp/xul/treestyletab/
Other
3.48k stars 279 forks source link

[Bug] Dragging collapsed folders sometimes results in tabs leaving tab folder/group hierachy #3567

Closed NefariousFerris closed 3 months ago

NefariousFerris commented 4 months ago

Attached is an example of a group hierachy that I dragged, while the parent group was collapsed. And another example of what ends up happening when moved to a different window

Screenshot 2024-06-03 114234

Screenshot 2024-06-03 114339

Abstract

Steps to reproduce

  1. Start Firefox with clean profile.
  2. Install TST.

Expected result

Actual result

Environment

piroor commented 3 months ago

I missed this case if those group tabs have any checked "Close this tab when...". TST cleans them up automatically while tabs are moved across windows because those tabs lose their children while moving tabs. I've implemented a mechanism to block unexpected cleaning of group tabs with no children with the commit df3a27b.

NefariousFerris commented 3 months ago

thank you @piroor , any way to disable that button being checked? I actually hate always try to uncheck that option, but it's the default with the "Operate Tabs" context menu function when creating a new group from tabs. Looked through the TST and TST more command settings but can't figure out a way to disable it

piroor commented 3 months ago

TST options => checking "Unlock Expert Options" => "New Tabs not from Existing Tabs" => "Default state of group tabs for each context" section has options for that.

NefariousFerris commented 3 months ago

@piroor thank you so much! I did change all 3 options to "check to nothing" but it still happening

piroor commented 3 months ago

How did you open group tabs? Those options affects only to group tabs newly opened by TST itself. For example, group tabs will have checked state even you change those options, if you open a group tab from a bookmark and its URL contains query options for checkboxes. (And of course, changing those options won't affect to existing group tabs.)

NefariousFerris commented 3 months ago

I am right clicking and doing it through the menu provided by the TST more command extension image

piroor commented 3 months ago

Ah, I didn't provide similar options to the addon...

NefariousFerris commented 3 months ago

Is there an easier way you would recommend?

piroor commented 3 months ago

It is not controllable from TST More Tree Commands for now, so I've introduced some changes ba82187 and added a new option to TST side: "Opened to group tabs from other addons via API". It will be available at the next release.

NefariousFerris commented 3 months ago

Thank you so much!! Can't wait!

github-actions[bot] commented 3 months ago

This issue has been closed due to no response within 14 days after labeled as "maybe fixed", 7 days after last reopened, and 7 days after last commented.

NefariousFerris commented 3 months ago

Thank you for pushing this so quick. I am now have a new issue where if I drag tabs to a folder that is collapsed, sometimes the tabs that were already in that folder end up in the folder below that folder.