search

piroor / treestyletab

Tree Style Tab, Show tabs like a tree.
http://piro.sakura.ne.jp/xul/treestyletab/
Other
3.48k stars 279 forks source link

[Bug] Animations play when re-rendering tabs with virtual scrolling enabled #3572

Closed awused closed 3 months ago

awused commented 3 months ago

Abstract

I usually have animations on, but with virtual scrolling the tab elements animate into place when they re-render.

Steps to reproduce

  1. Keep animations and virtual scrolling enabled
  2. Open a lot of tabs and arrange them into trees
  3. Scroll up and down

Expected result

Scrolling up and down should not result in any animations playing, since no tabs are actually changing positions or states.

Actual result

Animations play as tabs translate themselves into position. This is often more apparent when scrolling down as scrolling up is more broken with virtual scrolling.

Environment

awused commented 3 months ago

This is also way more apparent with outOfScreenTabsRenderingPages set to 0 instead of 1.

piroor commented 3 months ago

I've found a bugs which can produce this kind problem (re-applying needless animation effect) and introduced patches to fix it. Could you try the development build? https://github.com/piroor/treestyletab?tab=readme-ov-file#development-builds

awused commented 3 months ago

Testing 4.0.17, it doesn't play the animations on scrolling anymore.