search

piroor / treestyletab

Tree Style Tab, Show tabs like a tree.
http://piro.sakura.ne.jp/xul/treestyletab/
Other
3.48k stars 279 forks source link

[Bug] Shift + Opt + Right/Left Arrow override? #3575

Closed alexa-llibre closed 3 months ago

alexa-llibre commented 3 months ago

Hello, after updating to the newest version of TST and changing no other settings for TST or anywhere on my computer (Mac), whenever I try to use the Shift + Opt + Right/Left Arrow keyboard shortcut to select text, it instead collapses the TST tree the selected tab belongs to. If I press those keys again immediately afterward it will move to the previous or next tab. I believe this is related to the TST new shortcut (from the release notes: "Add new keyboard shortcut slots "Simulate Up/Down/Left/Right Key on Tree" and assign default shortcuts Alt-Shift-Up/Down/Left/Right. They provide both spatial focus move on faviconized tabs and collapse/expand tree like arrow keys on tree items.").

I need to be able to opt out of the TST keyboard shortcut to keep my shortcuts as is (i.e. Shift Option Right/Left Arrow should select text, not do anything with TST). Thank you for your help!

CodingKoopa commented 3 months ago

This seems to have been introduced with 4.0.16 (2024.6.9):

Add new keyboard shortcut slots "Simulate Up/Down/Left/Right Key on Tree" and assign default shortcuts Alt-Shift-Up/Down/Left/Right. They provide both spatial focus move on faviconized tabs and collapse/expand tree like arrow keys on tree items.

Similar issue to #1995.

piroor commented 3 months ago

Sorry I didn't know "Alt" has different function on macOS. I've pushed a change to reassign default shortcuts as "MacCtrl+Shift+Up/Down/Left/Right".

And you can unassign those shortcuts with the addons manager: image

mfn commented 3 months ago

Thanks, that also fixed it for me. Was quite confused, because such a keystroke in a text area (like here on github) suddenly jumped to a different tab 💥

dimitarvp commented 3 months ago

@piroor This fixed it for me, thanks a lot.

For reference: I landed here from https://connect.mozilla.org/t5/discussions/option-shift-arrow-now-switches-tabs-since-v-127/m-p/59302 and https://bugzilla.mozilla.org/show_bug.cgi?id=1901978

alexa-llibre commented 3 months ago

Thank you! Also fixed for me - appreciate your quick response!

codeboten commented 3 months ago

Thank you for the details! This will save me many minutes of frustration on a daily basis!

isometricmax commented 3 months ago

Got here from the firefox subreddit, and @piroor's solution fixed it. Thanks!

gotofritz commented 3 months ago

This was so irritating I almost ditched Firefox for Brave... luckily someone on the Mozilla forum pointed me here. Please don't do this again 😄

ionut-mntn commented 3 months ago

Indeed very irritating. Glad it's solved & found this: https://support.mozilla.org/en-US/questions/1449863 which led me here.

All good now image All good now

Btw you mention you pushed it.. but does that mean it also reached prod? ie: I used Tamper Monkey to install Tree Style Tabs extension and usually whenever I open up firefox - if there is any update, then Tamper Monkey asks me if I want to install it (in case I have not configured that specific script to be auto-updated)... and saw no no update for the Tree Style Tabs today when I opened my browser.

piroor commented 3 months ago

A new version TST 4.0.18 containing fix for this is already uploaded to the addons website but not published yet because it is still in reviewed...

github-actions[bot] commented 3 months ago

This issue has been closed due to no response within 14 days after labeled as "fixed", 7 days after last reopened, and 7 days after last commented.