search

piroor / treestyletab

Tree Style Tab, Show tabs like a tree.
http://piro.sakura.ne.jp/xul/treestyletab/
Other
3.48k stars 279 forks source link

[Bug] TST is causing all panels of the Firefox Sidebar to have accessible name of "Tree Style Tab" #3586

Closed anna-yeddi closed 2 months ago

anna-yeddi commented 3 months ago

Abstract

TST is causing all panels of the Firefox Sidebar to have accessible name of "Tree Style Tab" - it looks like the extension is overwriting the label of the sidebar's toolbarbutton and it is not allowing any further changes to happen when other views of the sidebar are opened.

This is a high severity accessibility issue because it would prevent users of assistive technologies from identifying currently opened sidebar view, unless they review the content (they'd need to guess, especially, if a screen reader user has cognitive disability and rely on a screen reader to understand the content). Also, users of speech-to-text software like Voice Control would have to use a workaround to activate the view toggle, because calling its on-screen name would not work.

Steps to reproduce

  1. Start Firefox with clean profile.
  2. Install TST.
  3. Have a Fx sidebar opened, i.e. with ctrl/cmd+B open a Bookmarks sidebar and change to Tree Style Tabs
  4. In the sidebar, select the History view (or any other)
  5. Confirm the sidebar view is updated and its visual title is changed to History
  6. Using a screen reader, navigate to and observe the announcement of the History control at the top of the sidebar.
    1. Alternatively, open a browser developer tools > Accessibility > and select the sidebar's title button via the Pick accessible object from the page

Expected result

  1. The on-screen name of the sidebar is serving as an accessible name of the button and is announced as History (which would be the name field value in the A11y dev tools)

Actual result

  1. The on-screen name of the sidebar is updated to History but the accessible name of the button remains as the previous sidebar view, i.e. Tree Style Tabs (which is also the name field value in the A11y dev tools) View from the Firefox browser Dev Tools > Accessibility is attached. Button with on-screen text AI Chatbot has accessible name Tree Style Tab in the Accessibility tree

Environment

piroor commented 3 months ago

This looks to be a bug of Firefox itself. We can see same problem with other sidebar addons, like Sidebery. Please file a bug at bugzilla.mozilla.org instead here.

anna-yeddi commented 3 months ago

Please file a bug at bugzilla.mozilla.org instead here.

It's linked in the issue too.

Thank you for your investigation. I'll add it to the Bugzilla ticket for further investigations :)

piroor commented 3 months ago

Oh, sorry I missed the link...

piroor commented 2 months ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1905771 is now fixed.