[Enhancement] Automatically ungroup tabs when closing expanded tab group

sersorrel commented 3 months ago

Abstract

At the moment, if you choose "When a parent tab with Expanded Tree is closed/moved, Replace closed/moved parent with a Group Tab", then closing a group tab just causes it to instantly open again i.e. it effectively does nothing. It would be useful, I think, if that would instead perform the "ungroup tabs" action to remove the group tab from the hierarchy,

Steps to see the situation

Start Firefox with clean profile.
Install TST.
Under "When a parent tab is Closed or Moved", select "Recommended preset using Consistent Tab Behaviors controlled under TST" -> "When a parent tab with Expanded Tree is closed/moved, Replace closed/moved parent with a Group Tab"
Open 2+ child tabs of a parent tab:
```
Parent
|- Child 1
|- Child 2
```
Close the parent tab:
```
Group
|- Child 1
|- Child 2
```
Close the newly-created group tab:
```
Group
|- Child 1
|- Child 2
```
The group tab reopened itself!

Expected result

I think you should end up with a structure like this:

Child 1
Child 2

Actual (present) result

You actually end up with a structure like this:

Group
|- Child 1
|- Child 2

Environment

Platform (OS): NixOS 24.11.20240701.00d80d1
Version of Firefox: 127.0.2
Version (or revision) of Tree Style Tab: 4.0.20

piroor commented 3 months ago

OK, done with the commit b60a592 and b5fe6d6. Setting a new secret option closeParentBehavior_replaceWithGroup_thresholdToPrevent to a negative value (like -1) will take back the old behavior.

github-actions[bot] commented 2 months ago

This issue has been closed due to no response within 14 days after labeled as "fixed", 7 days after last reopened, and 7 days after last commented.

piroor / treestyletab