search

piroor / treestyletab

Tree Style Tab, Show tabs like a tree.
http://piro.sakura.ne.jp/xul/treestyletab/
Other
3.5k stars 278 forks source link

[Bug] Pressing Ctrl+Shift+, rearranges all tabs in all windows #3656

Open npjones101 opened 1 day ago

npjones101 commented 1 day ago

Abstract

Steps to reproduce

  1. Create a set of nested tabs
  2. Press Ctrl+Shift+, (comma)

Expected result

Nothing should happen with no key combo mapped to TST.

Actual result

A selection of tabs in all windows are extracted from their current position and moved up into their own tree.

This came up because for a long time I had that keyboard shortcut mapped to outdent a tab. No other extension has this key combination mapped.

Environment

piroor commented 23 hours ago

TST has no default shortcut with the key combination. Did you unexpectedly set that?

npjones101 commented 14 hours ago

I had originally set that as a shortcut for outdent and that worked fine for months. But when this started happening I cleared the shortcut and set it to a different key combo. That other key combo works fine to outdent but pressing Ctrl+Shift+, still causes the tree shuffle which makes me think it's an odd interaction with some new thing in Firefox.

I created this issue because I accidentally used the old key combo and messed up all my open trees. But one other thing I noticed when interacting with the messed up tabs is that TST behaved really oddly. With some of the tree, clicking the expand carat made tabs expand/collapse below the adjacent tab instead of immediately under the tab being expanded. I restarted Firefox which restored the tabs, but they were still messed up in that way until I started dragging them back to where they should be.